Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export UnicodeProtobufEnumAttribute and make prefix optional #53

Merged
merged 2 commits into from
May 17, 2024
Merged

Export UnicodeProtobufEnumAttribute and make prefix optional #53

merged 2 commits into from
May 17, 2024

Conversation

Roytangrb
Copy link
Contributor

@Roytangrb Roytangrb commented May 15, 2024 •
edited
Loading

  • Add UnicodeProtobufEnumAttribute back to module __init__.py
  • Make enum prefix optional (default to empty string) so db stored enum.Name as-is by default

Test:

  • unit test
  • pip install -e ./pynamodb-attributes from another local repo to test import and save

@Roytangrb Roytangrb requested review from knap1930 and mateog-lyft May 15, 2024 23:35
@Roytangrb Roytangrb marked this pull request as ready for review May 15, 2024 23:35
@knap1930
Copy link
Contributor

knap1930 commented May 15, 2024 •
edited
Loading

I wonder why this was never added before ¯\(ツ)/¯

@Roytangrb
Copy link
Contributor Author

I wonder why this was never added before ¯_(ツ)_/¯

probably just missed in the original PR #42

@Roytangrb Roytangrb merged commit af4b50f into master May 17, 2024
4 checks passed
@Roytangrb Roytangrb deleted the rtang/fix-pb-enum-export branch May 17, 2024 15:03
@Roytangrb
Copy link
Contributor Author

Publish to PyPI failed I am looking at the PyPI account issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knap1930 knap1930 knap1930 approved these changes

@mateog-lyft mateog-lyft Awaiting requested review from mateog-lyft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Roytangrb @knap1930